-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(codemod/biome_js_analyze): derive Applicability
for all lint rule actions
#2889
Conversation
CodSpeed Performance ReportMerging #2889 will not alter performanceComparing Summary
|
d895aff
to
8f19c6d
Compare
To get the tests to pass, I had to change the fix_kind for these rules:
All of these appeared to be emitting safe fixes before, so I've updated the fix_kind accordingly. |
8f19c6d
to
9738124
Compare
Should we implement |
I don't think so. You're right in that it would reduce some of the boilerplate, but IMO it's inconsequential. To me, the I do agree with the name change though. |
Fair enough. Let's change the name and merge it :) |
I suggested |
I suggested implementing |
Yeah it makes sense, now that I read more of the docs.
|
9738124
to
cd99dc8
Compare
Summary
Following up on the previous PR, #2885, this changes all the JS rules to derive their applicability from the
FixKind
supplied in the metadata. Should completely resolve #2799.closes #2799
closes #2797
Test Plan
Should compile and pass tests.